fix trailing newline parse bug #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix in vyperlang#1720 stopped working because the modified source code was only being provided to some compilation steps (compile_codes) but not others (get_interface_codes).
Codecov Report
@@ Coverage Diff @@
## master #2412 +/- ##
==========================================
+ Coverage 85.47% 85.51% +0.03%
==========================================
Files 91 91
Lines 9034 9034
Branches 2151 2151
==========================================
+ Hits 7722 7725 +3
+ Misses 806 804 -2
+ Partials 506 505 -1
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #2410
The previous fix in #1720 stopped working because the modified source
code was only being provided to some compilation steps (compile_codes)
but not others (get_interface_codes).
How I did it
Move the additional newline upstream
How to verify it
Compile the code in the issue
Description for the changelog
Cute Animal Picture